search: Make sure to destroy old provider displays when we unregister

When we unregistered providers, like when we refreshed the list of
active remote providers, we would forget to destroy the old provider
display after the fact. This left an empty "skeleton" provider display
still in the search results that would never be filled in. Make sure
to destroy it properly.

https://bugzilla.gnome.org/show_bug.cgi?id=728597

diff --git a/js/ui/search.js b/js/ui/search.js
index 919642a9a192ca5f7cab19adf7fbd2365e430c22..3797b74219de1eaa179a2044e05f44cd59b843d4 100644 (file)
--- a/js/ui/search.js
+++ b/js/ui/search.js
@@ -68,6 +68,9 @@ const SearchSystem = new Lang.Class({
     _unregisterProvider: function (provider) {
         let index = this._providers.indexOf(provider);
         this._providers.splice(index, 1);
+
+        if (provider.display)
+            provider.display.destroy();
     },
 
     getProviders: function() {